MBS-13740: Split report strings into reports translation component #3364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13740
Description
Reports are a lot less critical (and include a lot longer strings) than most of the rest of the Server translation component.
Them being in the main Server component means translators spend time working on them early that could be better spent translating other strings a lot more important for daily use of the site, such as relationships and attributes (and the rest of the Server code). Since Server is one of the components we expect to be reasonably complete before we put a language on beta and pretty much complete before we put it on production, this also means an unnecessary delay in making translations available.
Most report strings are also a lot more similar to each other than to the rest of the Server strings, so them being grouped seems like it would simplify translation.
Testing
Tested manually that the report index page loads and shows the right translations.
Notes
I copied the strings into the reports
.po
files with:The migration worked fine but left in the non-report file comments in the
.po
files - hopefully Weblate can remove those later?There's an issue here (which means this is a draft for now) in that I understand currently every string in the
/report
folder will be looked at as anl_reports
string, even if it just usesl
. There's a few headers and whatnot (such as "Artist", "URL") which would seem silly to move to the reports component, since they should always be the same as elsewhere.Further action
history
master
intobeta
That should clean up the files for the translation domain
mb_server
.