Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: onClick logic for ArtistsOverview and AlbumsOverview #536

Merged

Conversation

Shreyassp002
Copy link
Contributor

This PR focuses on improving the onClick logic for ArtistsOverview and AlbumsOverview by delegating the click handling to the parent composable (OverviewScreen). The changes ensure consistency with RecentlyPlayedOverview and centralize business logic for better separation of concerns and reusability.

Key Changes

  • Updated ArtistsOverview and AlbumsOverview to accept onClick lambdas from the parent.
  • Moved the logic for handling clicks (e.g., changePlayable and playOrToggleSong) to OverviewScreen.
  • Added null-safety checks and proper handling of empty lists in AlbumsOverview.

Before:

video_2025-01-26_19-13-49.mp4

After:

video_2025-01-26_19-13-44.mp4

@07jasjeet
Copy link
Collaborator

Hi @Shreyassp002, Thanks for fixing this issue. Great work :)

@07jasjeet 07jasjeet merged commit 2d22071 into metabrainz:main Jan 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants