Fixed UI State Loss In BrainzPlayerSearchScreen #534
Conversation
There was a problem hiding this comment.
Hi @rahul31124, thanks for picking this up. You hit the correct spot by using view-model to preserve state!! But, there are better ways to do this task for which I have left comments in the review itself :)
| onQueryChange = { newValue: String -> | ||
| val updatedQuery = TextFieldValue(newValue, selection = brainzplayerQueryState.selection) | ||
| viewModel.updateSearchQuery(updatedQuery) | ||
| viewModel.searchSongs(newValue) |
There was a problem hiding this comment.
Hi, we should not call this search function here itself, but in the view-model. We want to debounce this request by about 100-200 millisecs (since its local search, otherwise we prefer 500 when network calls are required). Please take inspiration from the following line:
You can go through SearchViewModel.kt to derive your logic for searching.
There was a problem hiding this comment.
Hi @07jasjeet ,
I have refactored the BrainzPlayerViewModel and BrainzPlayerSearchScreen as per the guidance,could you please review and let me know if everything looks good?
Thank you!
|
@rahul31124 Thanks for the contribution! |
This PR resolves the issue of UI state loss in BrainzPlayerSearchScreen during screen orientation changes. Previously, the search query and UI state were reset when the screen rotated. This issue has been fixed by introducing state retention in BrainzPlayerViewModel and ensuring that the UI state, including the search query and results, is preserved across orientation changes.
Before
Orientation_Before.mp4
After
Orientation_After.mp4