Bugfix: null song is coming when we click on recently played #533
+94
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07jasjeet
approved these changes
Jan 26, 2025
|
Thanks for the contribution @GautamCoder4019k! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where clicking on recently played list a null song gets added to the playlist. The issue occurred due to adding a empty song object to the recent played list and that empty song object was just used for checking if we should show all recently played card or not. In this pr i changed the logic for that and also refractor the code.
Earlier
WhatsApp.Video.2025-01-25.at.23.57.39_dae974d8.mp4
Now
WhatsApp.Video.2025-01-25.at.23.55.29_8f384cb2.mp4