Chore: removed dropdown functionality from the BP tabs #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Shreyassp002 I think there has been a confusion, we only wanted to remove the tab from Albums screen only. In this comment I quoted "every item in tab" (where the tab's context was Albums tab) and not "every tab". This is an understandable mistake, more from my side for not communicating clearly. Please just remove dropdown from album's tab and revert rest of the removals. Also, this part of code has been updated by me so you may go through the pain of resolving conflicts haha. It should be a good practice to know how to resolve conflicts as its a very useful skill to have :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on removing the dropdown functionality from the BrainzPlayer tabs to address the buggy behavior and improve the overall user experience. The changes ensure a cleaner and more consistent UI across the affected screens.
Updated files:
Screenshot:
Let me know if further adjustments are needed!
Note: Please merge this PR after PR #518.