Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Delete song from BrainzPlayer playlist #519

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

Shreyassp002
Copy link
Contributor

This PR resolves a bug where songs were not being deleted from the playlist in the BrainzPlayer screen. The following changes were made.

  • Updated the logic in BrainzPlayerBackDropScreen.kt to properly remove the selected songs (checkedSongs) from the playlist.
  • Ensured that the currentPlayable's song list is mutable and modified correctly during the deletion process.

These updates ensure a smoother user experience when managing playlist in the BrainzPlayer feature.

Before:

video_2025-01-01_23-46-14.mp4

Fixed:

video_2025-01-01_23-46-09.mp4

Let me know if there are any changes needed!

Copy link
Collaborator

@07jasjeet 07jasjeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. We also need to re-think this checked box design-wise because its very out of line wrt to the app.

@07jasjeet 07jasjeet merged commit 99791fc into metabrainz:main Jan 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants