Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: FollowButton state management and minor ui bugs #506

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

Shreyassp002
Copy link
Contributor

@Shreyassp002 Shreyassp002 commented Dec 15, 2024

This PR addresses issues where the Follow button state was not updating correctly across the ListenScreen and BaseProfileScreen also some ui bugs fixes. The following changes have been made:

  • Corrected the styling of the Follow Button to match the light theme.
  • Fixed text color inconsistencies in the Compatibility section for better visual consistency.
  • Fixed Follow Button state management across ListenScreen and BaseProfileScreen.

Screenshots

Issue:

issue 1

issue 2

issue 3

Screenrecorder-2024-12-17-19-55-10-500.mp4

Fixes:

Screenshot_2024-12-15-23-36-40-908_org listenbrainz android debug

Screenshot_2024-12-15-23-37-03-659_org listenbrainz android debug

Screenshot_2024-12-15-23-37-54-849_org listenbrainz android debug

Screenrecorder-2024-12-17-19-57-05-755.mp4

Let me know if there are any changes needed to the color scheme or any other adjustments!

@Shreyassp002 Shreyassp002 changed the title Fix: FollowButton and compatibilty color scheme in light theme Fix: FollowButton state management and minor ui bugs Dec 17, 2024
@07jasjeet
Copy link
Collaborator

Hi, thanks for the PR. We would like to keep the follow button same throughout the app, if you could replace the button with existing component entirely, it would be really great!

@Shreyassp002
Copy link
Contributor Author

Hi @07jasjeet ,

Thank you for the feedback! Just to ensure consistency:

  1. Could you confirm which existing button component you'd like me to replace the Follow button with? If possible, could you point me to the file or component name where it's implemented?

  2. Regarding the state management updates I made for the Follow button across the ListenScreen and BaseProfileScreen, should I revert those changes as well, or should I adapt them to work with the existing component?

@07jasjeet
Copy link
Collaborator

  1. @Shreyassp002 this is the component I'm talking about.
  2. State management changes look good, no need to revert.

@Shreyassp002
Copy link
Contributor Author

Shreyassp002 commented Dec 24, 2024

Hi @07jasjeet ,

I’ve updated the ListensScreen to use the requested component. The BaseProfileScreen already had the correct component in place, so no changes were needed there.

Fixes:
photo_2024-12-24_17-52-27
photo_2024-12-24_17-52-31

Please let me know if there is anything else that needs attention or further adjustments.

Copy link
Collaborator

@07jasjeet 07jasjeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last bit changes

Copy link
Collaborator

@07jasjeet 07jasjeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for fixing this UI issue!

@07jasjeet 07jasjeet merged commit 6ec7c05 into metabrainz:main Dec 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants