-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: FollowButton state management and minor ui bugs #506
Fix: FollowButton state management and minor ui bugs #506
Conversation
Hi, thanks for the PR. We would like to keep the follow button same throughout the app, if you could replace the button with existing component entirely, it would be really great! |
Hi @07jasjeet , Thank you for the feedback! Just to ensure consistency:
|
|
Hi @07jasjeet , I’ve updated the ListensScreen to use the requested component. The BaseProfileScreen already had the correct component in place, so no changes were needed there. Please let me know if there is anything else that needs attention or further adjustments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last bit changes
app/src/main/java/org/listenbrainz/android/ui/screens/profile/listens/ListensScreen.kt
Outdated
Show resolved
Hide resolved
…listens/ListensScreen.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for fixing this UI issue!
This PR addresses issues where the Follow button state was not updating correctly across the ListenScreen and BaseProfileScreen also some ui bugs fixes. The following changes have been made:
Screenshots
Issue:
Screenrecorder-2024-12-17-19-55-10-500.mp4
Fixes:
Screenrecorder-2024-12-17-19-57-05-755.mp4
Let me know if there are any changes needed to the color scheme or any other adjustments!