Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Close by drop on explicit close #55

Merged
merged 27 commits into from
Jun 13, 2024
Merged

Conversation

AZWN
Copy link
Collaborator

@AZWN AZWN commented Jun 6, 2024

No description provided.

@AZWN AZWN marked this pull request as draft June 6, 2024 16:01
@jdonszelmann
Copy link
Collaborator

using const generics and array pattern matching you can avoid the macros

@jdonszelmann
Copy link
Collaborator

put ScopeExt in an Rc

@jdonszelmann
Copy link
Collaborator

rename ScopeExt, as {something}Ext has a meaning in Rust

@AZWN AZWN marked this pull request as ready for review June 13, 2024 14:05
@AZWN AZWN merged commit 453dd02 into main Jun 13, 2024
11 checks passed
@AZWN AZWN deleted the close-by-drop-on-explicit-close branch June 13, 2024 14:06
@AZWN
Copy link
Collaborator Author

AZWN commented Jun 13, 2024

Ok, merged in for now. Needs follow-up, especially for the macro's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants