fix clippy #468
jdonszelmannrust.yml
on: push
Clippy
55s
Format
26s
Test Nightly
1m 51s
Test Beta
2m 9s
Test Stable
2m 6s
Annotations
20 errors and 30 warnings
|
Format
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/scopegraph.rs#L188
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/scopegraph.rs:188:6
|
188 | impl<'sg, LABEL, DATA, CMPL> ScopeGraph<'sg, LABEL, DATA, CMPL>
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
188 - impl<'sg, LABEL, DATA, CMPL> ScopeGraph<'sg, LABEL, DATA, CMPL>
188 + impl<LABEL, DATA, CMPL> ScopeGraph<'_, LABEL, DATA, CMPL>
|
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/scopegraph.rs#L136
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/scopegraph.rs:136:6
|
136 | impl<'sg, LABEL, DATA, CMPL> ScopeGraph<'sg, LABEL, DATA, CMPL>
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
136 - impl<'sg, LABEL, DATA, CMPL> ScopeGraph<'sg, LABEL, DATA, CMPL>
136 + impl<LABEL, DATA, CMPL> ScopeGraph<'_, LABEL, DATA, CMPL>
|
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/scopegraph.rs#L64
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/scopegraph.rs:64:6
|
64 | impl<'sg, LABEL: Hash + Eq, DATA> InnerScopeGraph<'sg, LABEL, DATA> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
64 - impl<'sg, LABEL: Hash + Eq, DATA> InnerScopeGraph<'sg, LABEL, DATA> {
64 + impl<LABEL: Hash + Eq, DATA> InnerScopeGraph<'_, LABEL, DATA> {
|
|
|
very complex type used. Consider factoring parts into `type` definitions:
scopegraphs/src/resolve/mod.rs#L379
error: very complex type used. Consider factoring parts into `type` definitions
--> scopegraphs/src/resolve/mod.rs:379:10
|
379 | ) -> Result<
| __________^
380 | | ResolvedPath<'sg, LABEL, DATA>,
381 | | OnlyElementError<
382 | | 'a,
... |
387 | | >,
388 | | > {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `-D clippy::type-complexity` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::type_complexity)]`
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/resolve/mod.rs#L180
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/resolve/mod.rs:180:6
|
180 | impl<'sg, LABEL, DATA> ResolvedPath<'sg, LABEL, DATA> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
180 - impl<'sg, LABEL, DATA> ResolvedPath<'sg, LABEL, DATA> {
180 + impl<LABEL, DATA> ResolvedPath<'_, LABEL, DATA> {
|
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/resolve/mod.rs#L168
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/resolve/mod.rs:168:6
|
168 | impl<'sg, LABEL, DATA> ResolvedPath<'sg, LABEL, DATA> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
168 - impl<'sg, LABEL, DATA> ResolvedPath<'sg, LABEL, DATA> {
168 + impl<LABEL, DATA> ResolvedPath<'_, LABEL, DATA> {
|
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/resolve/mod.rs#L159
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/resolve/mod.rs:159:6
|
159 | impl<'sg, LABEL: Clone, DATA> Clone for ResolvedPath<'sg, LABEL, DATA> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
159 - impl<'sg, LABEL: Clone, DATA> Clone for ResolvedPath<'sg, LABEL, DATA> {
159 + impl<LABEL: Clone, DATA> Clone for ResolvedPath<'_, LABEL, DATA> {
|
|
|
the following explicit lifetimes could be elided: 'a:
scopegraphs/src/resolve/mod.rs#L91
error: the following explicit lifetimes could be elided: 'a
--> scopegraphs/src/resolve/mod.rs:91:6
|
91 | impl<'a, LABEL> Iterator for PathScopeIterator<'a, LABEL> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
91 - impl<'a, LABEL> Iterator for PathScopeIterator<'a, LABEL> {
91 + impl<LABEL> Iterator for PathScopeIterator<'_, LABEL> {
|
|
|
the following explicit lifetimes could be elided: 'storage:
scopegraphs/src/resolve/lookup.rs#L106
error: the following explicit lifetimes could be elided: 'storage
--> scopegraphs/src/resolve/lookup.rs:106:6
|
106 | impl<'storage, 'sg: 'rslv, 'rslv, LABEL, DATA, CMPL, DWF, LO, DEq>
| ^^^^^^^^
107 | ResolutionContext<'storage, 'sg, 'rslv, LABEL, DATA, CMPL, DWF, LO, DEq>
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
106 ~ impl<'sg: 'rslv, 'rslv, LABEL, DATA, CMPL, DWF, LO, DEq>
107 ~ ResolutionContext<'_, 'sg, 'rslv, LABEL, DATA, CMPL, DWF, LO, DEq>
|
|
|
the following explicit lifetimes could be elided: 'fut:
scopegraphs/src/future_wrapper.rs#L33
error: the following explicit lifetimes could be elided: 'fut
--> scopegraphs/src/future_wrapper.rs:33:6
|
33 | impl<'fut, T: Clone> Future for FutureWrapper<'fut, T> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
33 - impl<'fut, T: Clone> Future for FutureWrapper<'fut, T> {
33 + impl<T: Clone> Future for FutureWrapper<'_, T> {
|
|
|
the following explicit lifetimes could be elided: 'fut:
scopegraphs/src/future_wrapper.rs#L14
error: the following explicit lifetimes could be elided: 'fut
--> scopegraphs/src/future_wrapper.rs:14:6
|
14 | impl<'fut, T> Clone for FutureWrapper<'fut, T> {
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
14 - impl<'fut, T> Clone for FutureWrapper<'fut, T> {
14 + impl<T> Clone for FutureWrapper<'_, T> {
|
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/completeness/explicit.rs#L202
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/completeness/explicit.rs:202:6
|
202 | impl<'sg, LABEL: Hash + Eq + Copy, DATA> ScopeGraph<'sg, LABEL, DATA, FutureCompleteness<LABEL>> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
202 - impl<'sg, LABEL: Hash + Eq + Copy, DATA> ScopeGraph<'sg, LABEL, DATA, FutureCompleteness<LABEL>> {
202 + impl<LABEL: Hash + Eq + Copy, DATA> ScopeGraph<'_, LABEL, DATA, FutureCompleteness<LABEL>> {
|
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/completeness/explicit.rs#L112
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/completeness/explicit.rs:112:6
|
112 | impl<'sg, LABEL: Hash + Eq, DATA> ScopeGraph<'sg, LABEL, DATA, ExplicitClose<LABEL>> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
112 - impl<'sg, LABEL: Hash + Eq, DATA> ScopeGraph<'sg, LABEL, DATA, ExplicitClose<LABEL>> {
112 + impl<LABEL: Hash + Eq, DATA> ScopeGraph<'_, LABEL, DATA, ExplicitClose<LABEL>> {
|
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/completeness/critical_edge.rs#L94
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/completeness/critical_edge.rs:94:6
|
94 | impl<'sg, LABEL: Hash + Eq, DATA, CMPL> ScopeGraph<'sg, LABEL, DATA, CMPL>
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
94 - impl<'sg, LABEL: Hash + Eq, DATA, CMPL> ScopeGraph<'sg, LABEL, DATA, CMPL>
94 + impl<LABEL: Hash + Eq, DATA, CMPL> ScopeGraph<'_, LABEL, DATA, CMPL>
|
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/completeness/critical_edge.rs#L71
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/completeness/critical_edge.rs:71:6
|
71 | impl<'sg, LABEL: Hash + Eq, DATA, CMPL> ScopeGraph<'sg, LABEL, DATA, CMPL>
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
71 - impl<'sg, LABEL: Hash + Eq, DATA, CMPL> ScopeGraph<'sg, LABEL, DATA, CMPL>
71 + impl<LABEL: Hash + Eq, DATA, CMPL> ScopeGraph<'_, LABEL, DATA, CMPL>
|
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/render/mod.rs#L47
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/render/mod.rs:47:6
|
47 | impl<'sg, LABEL, DATA> Default for RenderSettings<'sg, LABEL, DATA> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
47 - impl<'sg, LABEL, DATA> Default for RenderSettings<'sg, LABEL, DATA> {
47 + impl<LABEL, DATA> Default for RenderSettings<'_, LABEL, DATA> {
|
|
|
the following explicit lifetimes could be elided: 'sg:
scopegraphs/src/render/mod.rs#L39
error: the following explicit lifetimes could be elided: 'sg
--> scopegraphs/src/render/mod.rs:39:6
|
39 | impl<'sg, LABEL, DATA> RenderSettings<'sg, LABEL, DATA> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `-D clippy::needless-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
|
39 - impl<'sg, LABEL, DATA> RenderSettings<'sg, LABEL, DATA> {
39 + impl<LABEL, DATA> RenderSettings<'_, LABEL, DATA> {
|
|
|
elided lifetime has a name:
scopegraphs/src/resolve/mod.rs#L647
error: elided lifetime has a name
--> scopegraphs/src/resolve/mod.rs:647:9
|
642 | pub fn query<'sg>(
| --- lifetime `'sg` declared here
...
647 | '_,
| ^^ this elided lifetime gets resolved as `'sg`
|
= note: `-D elided-named-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(elided_named_lifetimes)]`
|
|
Clippy
Clippy had exited with the 101 exit code
|
|
Format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Format
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Nightly
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test Nightly
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Test Nightly
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Nightly
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Nightly
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Nightly
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Stable
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test Stable
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Test Stable
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Stable
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Stable
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Stable
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Beta
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test Beta
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Test Beta
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Beta
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Beta
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Beta
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|