Store and retrieve hash_zch_runtime_meta within mc_embbedding submodules #3599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 8, 2025 13:29
…3598) Summary: See https://fb.workplace.com/groups/1404957374198553/permalink/1610214197006202/ This diff extends `raw_id_tracker` to store `hash_zch_runtime_meta` which will be alongside with `hash_zch_identities` when presented. Note that it is possible that a mpzch table only has `hash_zch_identities` without `hash_zch_runtime_meta` but is not true vice versa. Differential Revision: D88600497
Summary: See https://fb.workplace.com/groups/1404957374198553/permalink/1610214197006202/ Similar to D85999577, we store the `hash_zch_runtime_meta` when it is being look up in `mc_modules.py` in `raw_id_tracker` then access it in `batched_embedding_kernel.py` which will then be streamed to the inference side (see the other diffs in this stack D87810125) Differential Revision: D88623165
Contributor
|
@FriedCosey has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88623165. |
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See https://fb.workplace.com/groups/1404957374198553/permalink/1610214197006202/
Similar to D85999577, we store the
hash_zch_runtime_metawhen it is being look up inmc_modules.pyinraw_id_trackerthen access it inbatched_embedding_kernel.pywhich will then be streamed to the inference side (see the other diffs in this stack D87810125)Differential Revision: D88623165