-
Notifications
You must be signed in to change notification settings - Fork 114
Startup 3.5x faster #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zdevito
wants to merge
4
commits into
gh/zdevito/144/base
Choose a base branch
from
gh/zdevito/144/head
base: gh/zdevito/144/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Startup 3.5x faster #2099
+39
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing various simple things that claude helped find. 1.7 seconds --> .5 seconds. * Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second! * We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start. * Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes. Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Dec 10, 2025
Fixing various simple things that claude helped find. 1.7 seconds --> .5 seconds. * Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second! * We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start. * Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes. Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)! ghstack-source-id: 328300953 Pull Request resolved: #2099
Fixing various simple things that claude helped find. 1.7 seconds --> .5 seconds. * Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second! * We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start. * Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes. Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Dec 10, 2025
Pull Request resolved: #2099 Fixing various simple things that claude helped find. 1.7 seconds --> .5 seconds. * Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second! * We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start. * Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes. ghstack-source-id: 328496691 @exported-using-ghexport Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)!
Fixing various simple things that claude helped find. 1.7 seconds --> .5 seconds. * Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second! * We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start. * Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes. Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Dec 10, 2025
Pull Request resolved: #2099 Fixing various simple things that claude helped find. 1.7 seconds --> .5 seconds. * Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second! * We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start. * Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes. ghstack-source-id: 328511693 @exported-using-ghexport Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)!
Fixing various simple things that claude helped find. 1.7 seconds --> .5 seconds. * Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second! * We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start. * Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes. Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Dec 10, 2025
Pull Request resolved: #2099 Fixing various simple things that claude helped find. 1.7 seconds --> .5 seconds. * Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second! * We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start. * Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes. ghstack-source-id: 328518444 @exported-using-ghexport Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixing various simple things that claude helped find.
1.7 seconds --> .5 seconds.
Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second!
We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in
inffor the first message, and just sends it, that way we do not add another 50 ms on every process start.Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes.
Differential Revision: D88810033
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!