Skip to content

Conversation

@zdevito
Copy link
Contributor

@zdevito zdevito commented Dec 10, 2025

Stack from ghstack (oldest at bottom):

Fixing various simple things that claude helped find.

1.7 seconds --> .5 seconds.

  • Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second!

  • We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in inf for the first message, and just sends it, that way we do not add another 50 ms on every process start.

  • Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes.

Differential Revision: D88810033

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

Fixing various simple things that claude helped find.

1.7 seconds --> .5 seconds.

* Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second!

* We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start.

* Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes.

Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)!

[ghstack-poisoned]
@zdevito zdevito mentioned this pull request Dec 10, 2025
zdevito added a commit that referenced this pull request Dec 10, 2025
Fixing various simple things that claude helped find.

1.7 seconds --> .5 seconds.

* Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second!

* We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start.

* Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes.

Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)!

ghstack-source-id: 328300953
Pull Request resolved: #2099
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 10, 2025
Fixing various simple things that claude helped find.

1.7 seconds --> .5 seconds.

* Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second!

* We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start.

* Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes.

Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)!

[ghstack-poisoned]
zdevito added a commit that referenced this pull request Dec 10, 2025
Pull Request resolved: #2099

Fixing various simple things that claude helped find.

1.7 seconds --> .5 seconds.

* Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second!

* We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start.

* Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes.
ghstack-source-id: 328496691
@exported-using-ghexport

Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)!
Fixing various simple things that claude helped find.

1.7 seconds --> .5 seconds.

* Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second!

* We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start.

* Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes.

Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)!

[ghstack-poisoned]
zdevito added a commit that referenced this pull request Dec 10, 2025
Pull Request resolved: #2099

Fixing various simple things that claude helped find.

1.7 seconds --> .5 seconds.

* Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second!

* We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start.

* Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes.
ghstack-source-id: 328511693
@exported-using-ghexport

Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)!
Fixing various simple things that claude helped find.

1.7 seconds --> .5 seconds.

* Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second!

* We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start.

* Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes.

Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)!

[ghstack-poisoned]
zdevito added a commit that referenced this pull request Dec 10, 2025
Pull Request resolved: #2099

Fixing various simple things that claude helped find.

1.7 seconds --> .5 seconds.

* Don't start the exponential backoff for initial connections at 50ms. We hit these like 20 times in a row and it adds up to 1/2 second!

* We need to rethink the batched aggregation interval. We probably need a simple predictor that assumes the average time between messages in `inf` for the first message, and just sends it, that way we do not add another 50 ms on every process start.

* Do not import ipython to check if ipython is active. If it isn't active this adds 1/2 second to startup time because it happens in three processes.
ghstack-source-id: 328518444
@exported-using-ghexport

Differential Revision: [D88810033](https://our.internmc.facebook.com/intern/diff/D88810033/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D88810033/)!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants