Quick fix for T246995730 #2031
Open
Quick fix for T246995730 #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Calling `hyperactor_telemetry::env::execution_url()` in unit tests is causing hangs. A line-by-line bisection shows that its this downstream graphql call that causes this https://fburl.com/code/b99kgut6. The simplest fix is to just not print it for now so we don't need to fully back out of D87273699 and make it easy to forward fix the full functionality Reviewed By: dulinriley Differential Revision: D88190271
meta-cla
bot
added
the
CLA Signed
|
@thomasywang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88190271. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Calling
hyperactor_telemetry::env::execution_url()in unit tests is causing hangs. A line-by-line bisection shows that its this downstream graphql call that causes this https://fburl.com/code/b99kgut6. The simplest fix is to just not print it for now so we don't need to fully back out of D87273699 and make it easy to forward fix the full functionalityReviewed By: dulinriley
Differential Revision: D88190271