Skip to content

[ENHANCEMENT] use websockets in cli template #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
burtenshaw wants to merge 17 commits into
base: release
Choose a base branch
from
Open

[ENHANCEMENT] use websockets in cli template #243

burtenshaw wants to merge 17 commits into from
+1,409 −116

Conversation

@burtenshaw
Copy link
Collaborator

@burtenshaw burtenshaw commented Dec 10, 2025 •
edited
Loading

This PR updates the cli template to use the websockets approach from #239 .

Before

env = __ENV_CLASS_NAME__Environment()

# Create the app with web interface and README integration
app = create_app(
    env,
    __ENV_CLASS_NAME__Action,
    __ENV_CLASS_NAME__Observation,
    env_name="__ENV_NAME__",
)

After

app = create_app(
    __ENV_CLASS_NAME__Environment,
    __ENV_CLASS_NAME__Action,
    __ENV_CLASS_NAME__Observation,
    env_name="__ENV_NAME__",
    max_concurrent_envs=1,  # increase this number to allow more concurrent WebSocket sessions
)

rycerzes and others added 11 commits December 4, 2025 23:01
@rycerzes
Add WebSocket support for environment interactions and enhance HTTP s…
85c47c6 
…erver capabilities

- Introduced WebSocketEnvClient for persistent sessions with multi-step interactions.
- Updated HTTPEnvServer to support WebSocket connections and manage multiple concurrent environments.
- Added WebSocket message types and responses for better communication.
- Enhanced Environment interface with concurrency safety attributes.
@rycerzes
impl concurrency management and session handling
e0a063d
@burtenshaw
add async to http server
95563b0
@rycerzes
Merge remote-tracking branch 'origin/async-http' into impl/concurrency
1584902
@rycerzes
concurrency config
3601357
@rycerzes
chore: add websockets to pyproject.toml
600acb4
@burtenshaw
add concurrency safe pram
a98851a
@burtenshaw
use factory in template app
8197d6f
@burtenshaw
us WS in client
f72b6da
@burtenshaw
expose ws classes
26b1148
@burtenshaw
add websocket examples to template readme
1ddd8d8
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 10, 2025
@burtenshaw
Copy link
Collaborator Author

burtenshaw commented Dec 10, 2025

@rycerzes We can merge this after #239 or into. It's up to you.

@rycerzes
Copy link
Contributor

rycerzes commented Dec 10, 2025

@rycerzes We can merge this after #239 or into. It's up to you.

Let's merge this into #239 so we can keep everything together and test it as one unit. I'll pull your changes in after addressing Lucain's review comments.

@burtenshaw
Copy link
Collaborator Author

burtenshaw commented Dec 10, 2025

@rycerzes ok. Can you merge this into your fork and I'll close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@burtenshaw @rycerzes