Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance download.sh with Verbose Logging, Error Handling, and Dependency Checks #314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nehalmr
Copy link

@nehalmr nehalmr commented Aug 12, 2024

Enhance download.sh with Verbose Logging, Error Handling, and Dependency Checks

Description:

This pull request improves the download.sh script by:

  1. Verbose Output: Enabled using set -ex to trace command execution and exit on errors.
  2. Dependency Checks: Added a check to ensure wget is installed before script execution.
  3. Error Handling: Implemented robust error handling to safely exit the script if any download or checksum verification fails.
  4. Progress Logging: Included clear progress messages to enhance user feedback during execution.

These changes ensure better usability and reliability for users downloading models.

Checklist:

  • Verified wget dependency.
  • Added error handling for all critical commands.
  • Tested script with different scenarios.
  • Updated the script to log progress clearly.

Testing:

The script was tested with various model sizes and under different network conditions to ensure stability and correct error handling. All scenarios were handled gracefully, with appropriate feedback provided to the user.

@facebook-github-bot
Copy link

Hi @nehalmr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 12, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@nehalmr
Copy link
Author

nehalmr commented Sep 10, 2024

Can you please review and respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants