PHP 8.4 compatibility #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> MessageBird\Client::__construct(): Implicitly marking parameter $httpClient as nullable is deprecated, the explicit nullable type must be used instead
Closed
|
@CoolGoose This one is ready for review. Could you please approve the workflow? |
Gobonoid
approved these changes
Nov 1, 2024
|
This reminds me that while it can be tempting to add dependencies, they often create more difficulties over time. I’ve decided to take this SDK out of our project and switch to using plain HTTP. |
|
Hi Ruud, I can't argue with that reasoning, but you did put the broken pipeline on our radar, so thank you for that 🙏 If after that fix is merged, you want to reopen this PR, we'd be happy to accept it. |
|
@ErikBooijMB Sure 👍 |
|
@ruudk That fix is now merged, if you can rebase this PR, I think it should be good to go 🔥 Thank you! |
|
@ErikBooijMB Done. Please approve the workflow |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221