Skip to content

Commit

Permalink
build: skip outdated node versions
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Only support Node versions of 10 and higher from now on.
  • Loading branch information
niekert committed Aug 30, 2019
1 parent 88bcde6 commit 31d5672
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 21 deletions.
16 changes: 2 additions & 14 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,10 @@
language: node_js
node_js:
- "12"
- "11"
- "10"
- "9"
- "8"
- "7"
- "6"
- "5"
- "4"
- "0.12"
- "0.10"
- "0.8"
- "iojs"
env:
- MB_ACCESSKEY="test_iQpAp0KCs5GCsMpDhIx2leuNB"
matrix:
allow_failures:
- node_js: "0.8"
- node_js: "iojs"

jobs:
include:
Expand Down
10 changes: 3 additions & 7 deletions lib/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1467,13 +1467,9 @@ queue.push(function () {
queue.push(function () {
nock('https://rest.messagebird.com')
.get('/groups/group-id')
.query(function (queryString) {
// nock isn't too forgiving when it comes to non-standard queries. The
// closest we can get to properly testing the query is comparing the
// encoded JSON. The query is, in fact, `_method=PUT&ids[]=first-id&ids[]=second-id`.
var expected = '{"_method":"PUT","ids":["first-id","second-id"]}';

return JSON.stringify(queryString) === expected;
.query({
'_method': 'PUT',
'ids[]': ["first-id","second-id"]
})
.reply(204, '');

Expand Down

0 comments on commit 31d5672

Please sign in to comment.