Remove boilerplate #132
Closed
Remove boilerplate #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @theopham1816, thanks for adding Lombok dependency to the project. However, this change can break backward compatibility. Also, 111 file changes are a lot. I need to test everything very well to make sure these changes don’t break anything. Let’s keep this PR open for a while. |
|
Hey @thaopham1816, thanks for the great job. |
|
I am going to close this PR because there is no plan to use Lombok soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#126 Remove boilerplate getters, setters, and exhaustive constructors using Lombok