added dependency to use assertReflectionEquals

messagebird · Jun 6, 2019 · 965744a · 965744a
1 parent 252c736
commit 965744a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 19 deletions.
diff --git a/api/pom.xml b/api/pom.xml
@@ -101,6 +101,12 @@
             <version>4.11</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.unitils</groupId>
+            <artifactId>unitils-core</artifactId>
+            <version>3.4.2</version>
+            <scope>test</scope>
+        </dependency>
         <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-core</artifactId>

diff --git a/api/src/test/java/com/messagebird/ContactTest.java b/api/src/test/java/com/messagebird/ContactTest.java
@@ -6,9 +6,9 @@
 import com.messagebird.objects.*;
 import org.junit.*;
 import org.mockito.Mockito;
-
 import static org.junit.Assert.*;
 import static org.mockito.Mockito.*;
+import static org.unitils.reflectionassert.ReflectionAssert.assertReflectionEquals;
 
 public class ContactTest {
 
@@ -78,20 +78,7 @@ public void testList() throws UnauthorizedException, GeneralException {
         verify(messageBirdServiceMock, times(1))
                 .requestList(Mockito.eq(CONTACTPATH), Mockito.eq(0), Mockito.eq(20),
                         Mockito.eq(ContactList.class));
-        assertEquals(response.getItems().get(0).getFirstName(), contactResponseList.getItems().get(0).getFirstName());
-        assertEquals(response.getItems().get(0).getLastName(), contactResponseList.getItems().get(0).getLastName());
-        assertEquals(response.getItems().get(0).getId(), contactResponseList.getItems().get(0).getId());
-        assertEquals(response.getItems().get(0).getCreatedDatetime(), contactResponseList.getItems().get(0).getCreatedDatetime());
-        assertEquals(response.getItems().get(0).getMsisdn(), contactResponseList.getItems().get(0).getMsisdn());
-        assertEquals(response.getItems().get(0).getCustomDetails().getCustom1(), contactResponseList.getItems().get(0).getCustomDetails().getCustom1());
-        assertEquals(response.getItems().get(0).getMessages().getHREF(), contactResponseList.getItems().get(0).getMessages().getHREF());
-        assertEquals(response.getItems().get(0).getMessages().getTotalCount(), contactResponseList.getItems().get(0).getMessages().getTotalCount());
-        assertEquals(response.getItems().get(0).getHref(), contactResponseList.getItems().get(0).getHref());
-        assertEquals(response.getItems().get(0).getGroups().getHREF(), contactResponseList.getItems().get(0).getGroups().getHREF());
-        assertEquals(response.getItems().get(0).getGroups().getTotalCount(), contactResponseList.getItems().get(0).getGroups().getTotalCount());
-        assertNotNull(response.getItems().get(0).getCreatedDatetime());
-        assertNotNull(response.getItems().get(0).getUpdatedDatetime());
-
+        assertReflectionEquals(response.getItems().get(0),contactResponseList.getItems().get(0));
     }
 
     @Test

diff --git a/api/src/test/java/com/messagebird/TestUtil.java b/api/src/test/java/com/messagebird/TestUtil.java
@@ -120,9 +120,9 @@ private static Contact createContact(){
         final CustomDetails customDetails = new CustomDetails();
         customDetails.setCustom1("ANY_DETAIL");
 
-        final MessageReference messageReferance =  new MessageReference();
-        messageReferance.setHREF("ANY_HREF");
-        messageReferance.setTotalCount(30);
+        final MessageReference messageReference =  new MessageReference();
+        messageReference.setHREF("ANY_HREF");
+        messageReference.setTotalCount(30);
 
         final GroupReference groupReference = new GroupReference();
         groupReference.setHREF("ANY_HREF");
@@ -135,7 +135,7 @@ private static Contact createContact(){
         contact.setCreatedDatetime(new Date());
         contact.setMsisdn("ANY_MSISDN");
         contact.setCustomDetails(customDetails);
-        contact.setMessages(messageReferance);
+        contact.setMessages(messageReference);
         contact.setHref("ANY_HREF");
         contact.setGroups(groupReference);
         contact.setUpdatedDatetime(new Date());