-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrap for fdk_aac #180
Add wrap for fdk_aac #180
Conversation
@thiblahute Has this been proposed upstream? |
Yes: mstorsjo/fdk-aac#139 |
bb2a5fd
to
ed861ea
Compare
From cmake: if(WIN32)
target_sources(aac-enc PRIVATE win32/getopt.h)
target_include_directories(aac-enc PRIVATE win32)
endif() Windows CI fails due to:
|
Most of the time that means your dll does not export any symbol. Check if cmake has a .def file, or some macro defined to dllexport. |
Looks all good to me now, and CI passed \o/ |
No description provided.