Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrap for fdk_aac #180

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Add wrap for fdk_aac #180

merged 1 commit into from
Oct 6, 2021

Conversation

thiblahute
Copy link
Contributor

No description provided.

releases.json Outdated Show resolved Hide resolved
@xclaesse
Copy link
Member

xclaesse commented Oct 5, 2021

@thiblahute Has this been proposed upstream?

@thiblahute
Copy link
Contributor Author

@thiblahute Has this been proposed upstream?

Yes: mstorsjo/fdk-aac#139

@thiblahute thiblahute force-pushed the fdk-aac branch 3 times, most recently from bb2a5fd to ed861ea Compare October 5, 2021 20:04
releases.json Outdated Show resolved Hide resolved
@eli-schwartz
Copy link
Member

From cmake:

  if(WIN32)
    target_sources(aac-enc PRIVATE win32/getopt.h)
    target_include_directories(aac-enc PRIVATE win32)
  endif()

Windows CI fails due to:

[167/175] Compiling C object subprojects/fdk-aac-2.0.2/aac-enc.exe.p/aac-enc.c.obj
FAILED: subprojects/fdk-aac-2.0.2/aac-enc.exe.p/aac-enc.c.obj 
"cl" "-Isubprojects\fdk-aac-2.0.2\aac-enc.exe.p" "-Isubprojects\fdk-aac-2.0.2" "-I..\subprojects\fdk-aac-2.0.2" "-I..\subprojects\fdk-aac-2.0.2\libAACdec\include" "-I..\subprojects\fdk-aac-2.0.2\libAACenc\include" "-I..\subprojects\fdk-aac-2.0.2\libSYS\include" "-I..\subprojects\fdk-aac-2.0.2\libArithCoding\include" "-I..\subprojects\fdk-aac-2.0.2\libDRCdec\include" "-I..\subprojects\fdk-aac-2.0.2\libSACdec\include" "-I..\subprojects\fdk-aac-2.0.2\libSACenc\include" "-I..\subprojects\fdk-aac-2.0.2\libSBRdec\include" "-I..\subprojects\fdk-aac-2.0.2\libSBRenc\include" "-I..\subprojects\fdk-aac-2.0.2\libMpegTPDec\include" "-I..\subprojects\fdk-aac-2.0.2\libMpegTPEnc\include" "-I..\subprojects\fdk-aac-2.0.2\libFDK\include" "-I..\subprojects\fdk-aac-2.0.2\libPCMutils\include" "/MDd" "/nologo" "/showIncludes" "/W2" "/Od" "/Zi" "/Fdsubprojects\fdk-aac-2.0.2\aac-enc.exe.p\aac-enc.c.pdb" /Fosubprojects/fdk-aac-2.0.2/aac-enc.exe.p/aac-enc.c.obj "/c" ../subprojects/fdk-aac-2.0.2/aac-enc.c
../subprojects/fdk-aac-2.0.2/aac-enc.c(23): fatal error C1083: Cannot open include file: 'getopt.h': No such file or directory

@xclaesse
Copy link
Member

xclaesse commented Oct 5, 2021

LINK : fatal error LNK1181: cannot open input file 'subprojects\fdk-aac-2.0.2\fdk_aac.lib'

Most of the time that means your dll does not export any symbol. Check if cmake has a .def file, or some macro defined to dllexport.

@xclaesse
Copy link
Member

xclaesse commented Oct 6, 2021

Looks all good to me now, and CI passed \o/

@xclaesse xclaesse merged commit 10f9cea into mesonbuild:master Oct 6, 2021
@thiblahute thiblahute deleted the fdk-aac branch October 6, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants