Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/static ip display #269

Merged
merged 9 commits into from
Sep 17, 2024
Merged

Conversation

KomelT
Copy link
Contributor

@KomelT KomelT commented Aug 7, 2024

I added convertIntToIpAddress() and convertIpAddressToInt() .

It is a little janky but it converts INT to IP:
image

And also IP to INT:
image

The problem is that validator inheritances types from protobuf, so it expects a number instead of a string:
image

Can they be decoupled?

export class NetworkValidationIpV4Config {
.
.
.

@Hunter275
Copy link
Member

@KomelT I'll take a look at this when I'm finished with #266

@KomelT KomelT marked this pull request as draft August 9, 2024 15:21
@KomelT KomelT marked this pull request as ready for review August 25, 2024 08:29
@Hunter275 Hunter275 added bug Something isn't working minor change This is a minor change labels Sep 5, 2024
@Hunter275
Copy link
Member

@KomelT is this ready for prime time, it seems to be working for me

@KomelT
Copy link
Contributor Author

KomelT commented Sep 17, 2024

@Hunter275 great, than merge it.

@Hunter275
Copy link
Member

Reading from the device works fine but I cannot save

@Hunter275 Hunter275 merged commit 4d1227a into meshtastic:master Sep 17, 2024
3 checks passed
@KomelT KomelT deleted the fix/static-ip-display branch September 17, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor change This is a minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants