Huge UI facelift and upgrades to libs (including xterm migration) #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements a comprehensive UI facelift and migrates from the legacy xterm package to the modern @xterm/xterm package. The changes include:
Summary: Major UI/UX redesign with modernized styling, xterm v5 to v6 migration, dependency updates, and enhanced visual feedback throughout the application.
Key Changes:
- Migration from
xtermv5 to@xterm/xtermv6 with FitAddon for terminal functionality - Complete UI redesign with glass-morphism, gradient buttons, improved animations, and modern card layouts
- SerialMonitor reimplemented using xterm terminal directly instead of custom buffer rendering
- Addition of 23 new locale translation keys for "waiting_for_data" across all supported languages
Reviewed changes
Copilot reviewed 42 out of 46 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated 15+ dependencies including xterm migration, Nuxt 3.19→3.20, Vue 3.5.19→3.5.26, and various build tools |
| utils/terminal.ts | Updated import path from 'xterm' to '@xterm/xterm' |
| types/manifest.ts | New TypeScript interfaces for firmware manifest structure |
| tailwind.config.js | Added meshtastic color palette, custom animations (fade-in, glow, float), and extended shadows |
| stores/serialMonitorStore.ts | Added rawBuffer field to store unprocessed terminal data for xterm |
| stores/firmwareStore.ts | Added DTR reset line before RTS toggle for improved ESP32 reset behavior |
| public/img/devices/unknown-new.svg | New SVG device illustration with modern styling |
| i18n/locales/*.json | Added "waiting_for_data" translation key across 23 locale files; updated header_title in several locales |
| components/SerialMonitor.vue | Complete rewrite using xterm Terminal with FitAddon, removed log level filtering UI, modernized toolbar |
| components/targets/*.vue | UI refresh with modern card styling, improved spacing, and gradient buttons (Uf2, Esp32, EraseUf2, FlashHeader, ReleaseNotes) |
| components/LogoHeader.vue | Redesigned with gradient text effects, glow animations, and responsive sizing |
| components/Flash.vue | Converted to Teleport-based modals with backdrop blur and modern styling |
| components/Firmware.vue | Custom dropdown implementation replacing Flowbite with manual positioning and Teleport |
| components/Device.vue | Modal redesign with improved vendor tags, device cards, and modern layout |
| components/DeviceHeader.vue | Added icon, improved close button styling, accent line |
| assets/css/main.css | 240+ lines of new utility classes for modern UI components (btn-primary, card-modern, modals, etc.) |
| app.vue | Layout improvements with flex layout, animated step indicators, gradient footer, enhanced connection status |
| .gitignore | Added .playwright-mcp to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.