Fix windows-11 detection for non-float platform.release() values#720
Merged
ianmcorvidae merged 1 commit intomeshtastic:masterfrom Dec 21, 2024
Merged
Fix windows-11 detection for non-float platform.release() values#720ianmcorvidae merged 1 commit intomeshtastic:masterfrom
ianmcorvidae merged 1 commit intomeshtastic:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #720 +/- ##
=======================================
Coverage 60.99% 60.99%
=======================================
Files 24 24
Lines 3899 3899
=======================================
Hits 2378 2378
Misses 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(fixes #639)
@tuesdays if you get a chance, would you be able to test this? I'm defaulting to this being set as "not windows 11".