A small offering of unit test coverage #595
Conversation
… very very minor code cleanup where I remove a line of code that simply will not be reached.
…reversing the change I made.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 58.99% 59.38% +0.38%
==========================================
Files 23 23
Lines 3419 3422 +3
==========================================
+ Hits 2017 2032 +15
+ Misses 1402 1390 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
It looks like at present this doesn't add any non-commented-out tests -- I'm guessing you're still working on it? If not, let me know. |
|
@ianmcorvidae Yes, I apologize, been working with other stuff. Basically, I think I need more isolation around the Bluetooth library; it still seems to be calling code that looks for a Bluetooth device on whatever machine is running the unit tests. This won't fail on my machine (which has Bluetooth) but will fail on GitHub Actions' host node, which if I'm guessing, probably doesn't have Bluetooth. |
… Closing it solves issue. Problem with third test case is more complex; needs a mock of Bluetooth device.
…n when processed in CI/CD
…rlying code around connections before I change it more.
|
@ianmcorvidae I think I'm at a stopping point here; there's some details around the Bluetooth connection code that I need to understand better and maybe dig deeper on. I'll try to make draft PRs in the future. |
…ng now-obsolete test, adding test for non-CI environments
Increasing unit test line coverage a bit for some of the BLE classes; very very minor code cleanup where I remove a line of code that simply will not be reached.