Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial NODENUM_BROADCAST_NO_LORA implementation with NeighborInfo module #5087

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thebentern
Copy link
Contributor

Closes #5082

@thebentern
Copy link
Contributor Author

Untested. Need to make sure this is getting ignored by the PKC logic... it's probably not

@thebentern thebentern marked this pull request as draft October 17, 2024 12:41
@GUVWAF
Copy link
Member

GUVWAF commented Oct 17, 2024

Maybe we could add an isDM() method that checks for to != NODENUM_BROADCAST && to != NODENUM_BROADCAST_NO_LORA?

@thebentern thebentern marked this pull request as ready for review October 17, 2024 18:35
@GUVWAF
Copy link
Member

GUVWAF commented Oct 17, 2024

I think when this is applied, we can also relax the default and minimum broadcast intervals again? E.g. 30 min. and 15 min., respectively, would be OK if it's only going to MQTT and the PhoneAPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Limit neighbor info module to no-lora transport (MQTT)
2 participants