Use M5STACK_COREBASIC instead for M5STACK to avoid confusion

[lboue]

We can use M5STACK_COREBASIC instead for M5STACK which is a brand and not a model to avoid confusion.
M5STACK_COREBASIC = 77;

In fact, it's clear that some users have tried to use the M5Stack variant with a M5Stack Core2 or CoreS3 module.

[caveman99]

This, on the other hand, needs a change to the protobufs :-) meshtastic_HardwareModel_M5STACK_CORE is not defined there, meshtastic_HardwareModel_M5STACK is. Since it's not used anywhere else, you can leave the old value

[lboue]

Yes, this is the protobufs PR: meshtastic/protobufs#598

[lboue]

I think this is why M5STACK_COREBASIC has been defined is protobufs. So we can use M5STACK_COREBASIC instead for M5STACK which is a brand and not a model to avoid confusion.

[caveman99]

Let's leave the hardware enum as it is, it's not showing up anywhere in writing. more like a macro for code...

[caveman99]

sorry, corebasic is not core. The original support was made for the 2018 M5Stack Core. And this is what constitutes "M5STACK = 42". All other newer devices can be catered for and we can change the macros at will, but please don't discontinue use of slot 42 as this would be a breaking change AND waste.

Please change this PR in a way that it leaves the existing support functional and adds the new devices.

[lboue]

Thanks for the explanation