Update traceroute list naming #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikdale
reviewed
Dec 18, 2024
| } else if route.response && route.hopsTowards == 1 { | ||
| Text("\(route.time?.formatted() ?? "unknown".localized) - 1 Hop") | ||
| } else if route.response && route.hopsTowards == route.hopsBack { | ||
| let hopLabel = route.hopsTowards == 1 ? "Hop" : "Hops" |
There was a problem hiding this comment.
Question.
Shouldn't this also have .localized?
== 1 ? "Hop".localized : "Hops".localized
Thanks up front!
There was a problem hiding this comment.
Thanks for the note. Yes, this also led me down a path to utilize the swift localization for pluralizing.
bjpetit
force-pushed
the
traceroute-list-name-cleanup
branch
from
b124e1c to
5bb8d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This change updates the naming of traceroute entries based on the number of hops towards and back.
Why did it change?
This makes the description of traceroute items a bit more consistent.
How is this tested?
Ran through numerous permutations of traceroutes to ensure the naming was correct.
Screenshots/Videos (when applicable)
Checklist