Traceroute two-way direct support #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjpetit
force-pushed
the
traceroute-twoway-direct
branch
from
38d0e5a to
e66043a
Compare
bjpetit
force-pushed
the
traceroute-twoway-direct
branch
from
e66043a to
7608c60
Compare
bjpetit
force-pushed
the
traceroute-twoway-direct
branch
from
7608c60 to
60d6f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update traceroute handling to support displaying two-way direct traceroutes
Why did it change?
The firmware supports it, we should show the data in the app.
How is this tested?
Tested with node firmware that supports two-way traceroute, and a node that doesn't. If the two-way traceroute isn't supported, the snr will show up as unknown.
Screenshots/Videos (when applicable)
Checklist