Skip to content

Conversation

@RCGV1
Copy link
Member

@RCGV1 RCGV1 commented Nov 4, 2025

What changed?

Fixed the bug that you could not change the icon of the waypoint. We now display who last created a waypoint or last updated it.

Why did it change?

This changed because you could not see who made the waypoint without looking back in the notifications.

How is this tested?

Tested on my iphone

Screenshots/Videos (when applicable)

IMG_5099

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have verified whether these changes require an update to existing documentation or if new documentation is needed, and created an issue in the docs repo if applicable.
  • I have tested the change to ensure that it works as intended.

@RCGV1 RCGV1 changed the base branch from main to 2.7.6 November 4, 2025 22:36
@RCGV1 RCGV1 requested a review from Copilot November 4, 2025 22:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the waypoint functionality by adding creator/updater tracking, improving the emoji selection behavior, and applying consistent presentation styles across waypoint sheets.

  • Added tracking of waypoint creators and last updaters with display of node information
  • Improved emoji icon handling to keep the last emoji when multiple are pasted
  • Applied consistent presentation detents and drag indicators to waypoint sheets

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
MeshMap.swift Added presentation detents and drag indicators to waypoint form sheets for consistent UI
WaypointForm.swift Major refactor: removed NavigationStack wrapper, added creator/updater node tracking with async fetch, improved emoji handling logic
MeshMapContent.swift Added automatic annotation titles to map annotations
MeshPackets.swift Added tracking of createdBy and lastUpdatedBy fields when waypoints are created or updated
Localizable.xcstrings Updated localization strings: added "Created by:" and "Last updated by:", consolidated privacy policy text

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RCGV1 RCGV1 requested a review from garthvh November 6, 2025 20:35
@github-actions github-actions bot added the Stale Marked stale by the bot, will be closed automatically soon label Dec 7, 2025
@github-actions github-actions bot closed this Dec 14, 2025
@RCGV1 RCGV1 reopened this Dec 14, 2025
@github-actions github-actions bot removed the Stale Marked stale by the bot, will be closed automatically soon label Dec 15, 2025
@garthvh garthvh changed the base branch from 2.7.6 to main December 18, 2025 04:17
@RCGV1 RCGV1 changed the base branch from main to waypoint-created-and-edited-by December 30, 2025 18:54
@RCGV1 RCGV1 changed the base branch from waypoint-created-and-edited-by to main December 30, 2025 19:25
@RCGV1
Copy link
Member Author

RCGV1 commented Dec 30, 2025

Not sure how to resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant