Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] partial update, still erroring out on Docker related packages in unit testing #364

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nebula-aac
Copy link
Contributor

@nebula-aac nebula-aac commented Sep 11, 2023

Description

Notes for Reviewers

This PR updates Go to 1.21

  • Also updates kompose because kompose is on Kubernetes API 1.28

The only issues now is the testing failed at this portion:

ok      github.com/layer5io/meshkit/cmd/errorutil/internal/coder        (cached)
# github.com/docker/compose/v2/pkg/api
../../../../pkg/mod/github.com/docker/compose/[email protected]/pkg/api/dryrunclient.go:347:94: undefined: containerType.FilesystemChange
../../../../pkg/mod/github.com/docker/compose/[email protected]/pkg/api/dryrunclient.go:619:73: undefined: registry.AuthConfig
../../../../pkg/mod/github.com/docker/compose/[email protected]/pkg/api/dryrunclient.go:640:37: cannot use opts (variable of type volume.ListOptions) as "github.com/docker/docker/api/types/filters".Args value in argument to d.apiClient.VolumeList

Will be testing this through meshery and others to check if there's anything else we need to clean up.
Signed commits

  • Yes, I signed my commits.

@nebula-aac nebula-aac marked this pull request as draft September 11, 2023 00:01
@nebula-aac nebula-aac changed the title [chore] partial update, still erroring out on docker packages in test [chore] partial update, still erroring out on Docker related packages in unit testing Sep 11, 2023
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac nebula-aac marked this pull request as ready for review October 17, 2023 13:26
Copy link

stale bot commented Dec 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Dec 2, 2023
@leecalcote leecalcote added the issue/willfix This issue will be worked on label Dec 3, 2023
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Dec 3, 2023
@MUzairS15
Copy link

@nebula-aac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/willfix This issue will be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants