-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only 9 cards are visible at a time #1920
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Bhushan Deshmukh <[email protected]>
756c44d
to
368eacc
Compare
@bhushan354 adding it as an agenda item to the meeting minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping in.
Have you verified the performance of this change. How does it behave?
I have reverted the changes I have made earlier now trying to fix the exact bug |
What's the bug? |
@bhushan354 would we be discussing updates from you on this PR today? Note Weekly websites call : https://meet.layer5.io/websites |
@vishalvivekm , I was unable to find the bug, but I’m still working on it. Also, I wanted to ask why the changes I made to the code, like the UI updates, aren't reflecting on localhost. |
Description
This PR fixes #1852
Notes for Reviewers
Earlier, all the cards were displayed at once in meshery.io/catalog page, This MR contains changes which shows only 9 cards per page.
Signed commits