Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fixed the modal screen fit issue #1859

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Fix] Fixed the modal screen fit issue #1859

wants to merge 2 commits into from
+12 −1

Conversation

kanishk6103
Copy link
Contributor

Description

This PR fixes #1803

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@kanishk6103
fixed modal screen fit issue
cfe45ac 
Signed-off-by: kanishk6103 <[email protected]>
@netlify Netlify
Copy link

netlify bot commented Aug 12, 2024 •
edited
Loading

✅ Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 72a0c20
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66c396ca21d8e80008e36348
😎 Deploy Preview https://deploy-preview-1859--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kanishk6103 kanishk6103 mentioned this pull request Aug 12, 2024
Closed
1 task
@leecalcote
Copy link
Member

@amitamrutiya would you like to offer review on this PR?

amitamrutiya
amitamrutiya reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@amitamrutiya amitamrutiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the extra comment; otherwise, LGTM.

_sass/catalog.scss Outdated Show resolved Hide resolved
@amitamrutiya amitamrutiya mentioned this pull request Aug 17, 2024
Closed
@Ashparshp
Copy link

@kanishk6103, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@kanishk6103
removed comment
72a0c20 
Signed-off-by: Kanishk Tiwari <[email protected]>
@stale Stale
Copy link

stale bot commented Sep 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 21, 2024
@Ashparshp Ashparshp added issue/remind Issue progress check and removed issue/stale Issue has not had any activity for an extended period of time labels Sep 21, 2024
@github-actions GitHub Actions
Copy link

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitamrutiya amitamrutiya amitamrutiya approved these changes

Assignees
No one assigned
Labels
area/website issue/remind Issue progress check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Catalog] Modals on Meshery Catalog are not fitting to the screen
4 participants
@kanishk6103 @leecalcote @Ashparshp @amitamrutiya