Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes docker image cross-build (part 2) #18

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

merschformann
Copy link
Owner

Description

This PR means to fix the arm64 docker image (cross-built on amd64) by using a self-contained single binary build (previously dotnet included amd64 .so files on an arm64 build for non-intuitive reasons). This should finally make the new linux/arm64 work properly.

Changes

  • Restructures SC.Service Dockerfile build to create a single binary build to wrap up in the docker image
    • Side-effect: reduces the docker image size from previously 327MB to 121MB
  • Reverts the default internal port to 80 for better backwards compatibility
  • Minor release script improvements

@merschformann merschformann merged commit efebefb into main Nov 4, 2024
1 check passed
@merschformann merschformann deleted the merschformann/fix-arm64-docker branch November 4, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant