-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Japanese README #6065
base: develop
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6065 +/- ##
=======================================
Coverage 4.48% 4.48%
=======================================
Files 383 383
Lines 54038 54038
Branches 596 596
=======================================
Hits 2425 2425
Misses 51613 51613
Flags with carried forward coverage won't be shown. Click here to find out more. |
I don't feel comfortable adding a new language, when it'll be outdated soon, as we don't have enough bandwidth to maintain the translations. Moreover, we have our docs in English only. Similar PR #4888 |
Thank you for checking and letting me know about the pull request for Hindi. I respect your take on this. I think there are three sustainable approaches.
Option 1: I'd like to propose the introduction of po4a, a translation maintenance tool based on gettext. It helps to automatically update the translations according to the original English texts, and to untranslate parts of them when they become outdated. Option 2, 3: If there are links to the translations, it will be easier to find them without much searching. Of course, it is possible for the link destination to be out of date or for the link to break. |
Thanks for the suggestion. If we're using machine translation like po4a, how much better would it be, than the browser's native translation feature? |
Thank you for your reply! I'd like to make it clear that po4a is not a machine translation tool; rather, it facilitates the manual translation process. Manual translation allows for a deeper understanding of the text, capturing nuances, idioms, and markups. While browser-native translation features can be helpful, they often lack the precision and quality that a manual approach provides. Even if someone has a translation extension, the effectiveness of the translation can vary, and having a dedicated manual process can significantly improve clarity and communication. In this pull request it is just the readme, but there is a lot of documentation available for Mermaid. I think it would be wonderful to be able to read this document fluently translated into different languages. |
@gemmaro do you mind adding the po4a files so we can get a better understanding of the process? |
a2a4865
to
e24cb57
Compare
|
@sidharthv96 I have added po4a files to the commit "docs: Add the translation update script and configs". These files do not get in the way of writing original documentation. They don't require any special markup in the source documents or additional configuration. |
📑 Summary
This adds a Japanese translation of the readme and links to it.
There are no related issues.
📏 Design Decisions
This doesn't change implementation; document additions only.
The translation has been done with reference to the prior work of @NurseAngel as in
README.ja-JP.md
, although there are many changes.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
. (Checked that this is not the case)