Cleanup prior to making logic changes

[jgreywolf]

📑 Summary

This PR is for small cleanup to code before making larger changes to address multiple issues related to class diagrams.
Ensure consistent naming between documentation and code, and remove an unnecessary function

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.
• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

[changeset-bot]

🦋 Changeset detected

Latest commit: 3e57d35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
mermaid	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	3e57d35
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/67586a7f6477aa00085b967a
😎 Deploy Preview	https://deploy-preview-6041--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6041

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6041

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6041

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6041

commit: 3e57d35

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 101 lines in your changes missing coverage. Please review.

Project coverage is 4.48%. Comparing base (df636c6) to head (3e57d35).

Files with missing lines	Patch %	Lines
packages/mermaid/src/diagrams/class/classDb.ts	0.00%	45 Missing ⚠️
packages/mermaid/src/diagrams/class/svgDraw.js	0.00%	16 Missing ⚠️
...ndering-util/rendering-elements/shapes/classBox.ts	0.00%	14 Missing ⚠️
packages/mermaid/src/diagrams/class/shapeUtil.ts	0.00%	12 Missing ⚠️
packages/mermaid/src/dagre-wrapper/nodes.js	0.00%	9 Missing ⚠️
packages/mermaid/src/diagrams/class/classTypes.ts	0.00%	4 Missing ⚠️
packages/mermaid-layout-elk/src/render.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #6041   +/-   ##
=======================================
  Coverage     4.48%   4.48%           
=======================================
  Files          383     383           
  Lines        54038   54024   -14     
  Branches       596     596           
=======================================
  Hits          2425    2425           
+ Misses       51613   51599   -14     

Flag	Coverage Δ
unit	4.48% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/mermaid-layout-elk/src/render.ts	0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/class/classTypes.ts	0.00% <0.00%> (ø)
packages/mermaid/src/dagre-wrapper/nodes.js	0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/class/shapeUtil.ts	0.00% <0.00%> (ø)
...ndering-util/rendering-elements/shapes/classBox.ts	0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/class/svgDraw.js	0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/class/classDb.ts	0.00% <0.00%> (ø)

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	⚠️ Changes detected (Review)	7 changed, 343 added, 343 removed, 4 failures	Dec 10, 2024, 4:33 PM

[jgreywolf]

@sidharthv96 @ashishjain0512 Can one of you please review? I would like to get this in place before I work on all of the pending classDiagram issues

[jgreywolf]

@aloisklink @sidharthv96 @ashishjain0512 @knsv

Can any of you help me figure out why these checks are failing?

[jgreywolf]

Closing