-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(state): add from, to ids for edge #6039
base: develop
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6039 +/- ##
=======================================
Coverage 4.49% 4.49%
=======================================
Files 383 382 -1
Lines 53925 53925
Branches 596 621 +25
=======================================
Hits 2425 2425
Misses 51500 51500
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
return `${prefix ? `${prefix}_` : ''}${from}_${to}_${counter}${suffix ? `_${suffix}` : ''}`; | ||
return `${prefix ? `${prefix}__` : ''}${from}__${to}__${counter}${suffix ? `__${suffix}` : ''}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this would break other tools that might be using edgeIDs for other diagrams. Why do we need double underscore?
Maybe we can introduce a parameter for separator?
📑 Summary
This PR reintroduces FROM-TO id in Edges.
#5503
📏 Design Decisions
I am currently working on converting state diagram to Excalidraw, and I felt the need to have an easier way to find the edges.
I tried some alternative paths but without success, for example:
.edgePaths
, however, the index does not always reflect how we iterate through the parser.doc.graphCount
id to get the edge, but in cases where we have multiple relationships for the same state, it may not find the correct edge because we do not have access to thegraphCount
in the parser.doc, only to the node id.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch