-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Class diagram namespaces black lines, not responding to theme variables #6026
base: develop
Are you sure you want to change the base?
Fix: Class diagram namespaces black lines, not responding to theme variables #6026
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6026 +/- ##
==========================================
- Coverage 4.50% 4.49% -0.01%
==========================================
Files 383 383
Lines 53875 53899 +24
Branches 622 622
==========================================
Hits 2425 2425
- Misses 51450 51474 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
@yari-dewalt Can you make sure to follow up on the failures listed? |
@yari-dewalt What is the status of this? Getting ready to make a slate of changes and figure it will be better to do after this |
📑 Summary
Gets rid of the default black line and transparent background styling of namespaces in class diagrams. This way the cluster is visually more consistent with other diagrams' clusters and is responsive to themes and custom theme variables.
Resolves #5669
📏 Design Decisions
Added common cluster styles from other diagrams and removed the hard coded cssStyles being applied to the namespace nodes.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.