Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Delete 'stroke: black' from lollipop marker so it matches themes and edge paths #6023

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

yari-dewalt
Copy link
Collaborator

📑 Summary

Currently if lollipop markers are used they are hard-coded to have a stroke of black. This PR removes that so it will match edge paths' strokes and work correctly with, for example, the dark theme.

📏 Design Decisions

Removes .attr('stroke', 'black') from the lollipop markers.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: 7a729e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 3c7fd95
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/672910825aaf600008abef1a
😎 Deploy Preview https://deploy-preview-6023--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 4, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@6023
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6023
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6023
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6023

commit: 7a729e8

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 7a729e8
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6729108faecc9f00082eb4bf
😎 Deploy Preview https://deploy-preview-6023--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

argos-ci bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 339 added, 339 removed, 1 failure Nov 4, 2024, 6:38 PM

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.50%. Comparing base (ece3b25) to head (7a729e8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6023   +/-   ##
=======================================
  Coverage     4.50%   4.50%           
=======================================
  Files          383     383           
  Lines        53875   53873    -2     
  Branches       622     622           
=======================================
  Hits          2425    2425           
+ Misses       51450   51448    -2     
Flag Coverage Δ
unit 4.50% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...d/src/rendering-util/rendering-elements/markers.js 0.00% <ø> (ø)

@jgreywolf
Copy link
Contributor

@yari-dewalt What is the status of this? Getting ready to make a slate of changes and figure it will be better to do after this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants