-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Delete 'stroke: black' from lollipop marker so it matches themes and edge paths #6023
base: develop
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6023 +/- ##
=======================================
Coverage 4.50% 4.50%
=======================================
Files 383 383
Lines 53875 53873 -2
Branches 622 622
=======================================
Hits 2425 2425
+ Misses 51450 51448 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@yari-dewalt What is the status of this? Getting ready to make a slate of changes and figure it will be better to do after this |
📑 Summary
Currently if lollipop markers are used they are hard-coded to have a stroke of black. This PR removes that so it will match edge paths' strokes and work correctly with, for example, the dark theme.
📏 Design Decisions
Removes
.attr('stroke', 'black')
from the lollipop markers.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.