chore(deps): update dependency @sveltejs/kit to v2.8.3 [security] #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
✅ Deploy Preview for mermaidjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Mermaid Live Editor
|
||||||||||||||||||||||||||||||
| Project |
Mermaid Live Editor
|
| Branch Review |
renovate/npm-sveltejs-kit-vulnerability
|
| Run status |
|
| Run duration | 03m 21s |
| Commit |
|
| Committer | renovate[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
6
|
Skipped
|
0
|
Passing
|
28
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Tests for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.8.1->2.8.3GitHub Vulnerability Alerts
CVE-2024-53262
Summary
The static error.html template for errors contains placeholders that are replaced without escaping the content first.
Details
From https://kit.svelte.dev/docs/errors:
This leads to possible injection if an app explicitly creates an error with a message that contains user controlled content that ends up being something like this inside a server handle function:
Uncaught errors cannot be exploited like this, as they always render the message "Internal error".
Escaping the message string in the function that creates the html output can be done to improve safety for applications that are using custom errors on the server.
PoC
None provided
Impact
Only applications where user provided input is used in the
Errormessage will be vulnerable, so the vast majority of applications will not be vulnerableCVE-2024-53261
Summary
"Unsanitized input from the request URL flows into
end, where it is used to render an HTML page returned to the user. This may result in a Cross-Site Scripting attack (XSS)."Details
Source of potentially tainted data is in
packages/kit/src/exports/vite/dev/index.js, line 437. This potentially tainted data is passed through a number of steps (which I could detail if you'd like) all the way down to line 91 inpackages/kit/src/exports/vite/utils.js, which performs an operation that Snyk believes an attacker shouldn't be allowed to manipulate.Another source of potentially tainted data (according to Snyk) comes from
packages/kit/src/exports/vite/utils.js, line 30, col 30 (i.e., theurlproperty ofreq). This potentially tainted data is passed through a number of steps (which I could detail if you'd like) all the way down line 91 inpackages/kit/src/exports/vite/utils.js, which performs an operation that Snyk believes an attacker shouldn't be allowed to manipulate.PoC
Not provided
Impact
Little to none. The Vite development is not exposed to the network by default. And even if someone were able to trick a developer into executing an XSS against themselves, a development database should not have any sensitive data.
Release Notes
sveltejs/kit (@sveltejs/kit)
v2.8.3Compare Source
Patch Changes
fix: ensure error messages are escaped (#13050)
fix: escape values included in dev 404 page (#13039)
v2.8.2Compare Source
Patch Changes
fix: prevent duplicate fetch request when using Request with load function's fetch (#13023)
fix: do not override default cookie decoder to allow users to override the
cookielibrary version (#13037)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.