Skip to content

update workflow, fixed bug to create build distribution#145

Open
adi-khot wants to merge 1 commit intomainfrom
publish-pipeline
Open

update workflow, fixed bug to create build distribution#145
adi-khot wants to merge 1 commit intomainfrom
publish-pipeline

Conversation

@adi-khot
Copy link
Contributor

Summary

Related Issue

Type of change

  • [ ✅] Bug fix
  • New feature
  • Documentation update
  • Refactor / Cleanup
  • Performance improvement
  • [ ✅] CI / Build / Tooling
  • Breaking change (requires migration notes)

Proposed changes

How to test / How to run

  1. Command lines
Block of code

Screenshots / Logs (optional)

Performance considerations (optional)

Documentation

  • User docs updated (Sphinx)
  • Examples / notebooks updated
  • Docstrings updated

Checklist

  • PR title includes Jira issue key (e.g., PML-126)
  • "Related Jira ticket" section includes the Jira issue key (no URL)
  • Code formatted (ruff format)
  • Lint passes (ruff)
  • Static typing passes (mypy) if applicable
  • Unit tests added/updated (pytest)
  • Tests pass locally (pytest)
  • Tests pass on GPU (pytest)
  • Test coverage not decreased significantly
  • Docs build locally if affected (sphinx)
  • Dependencies updated (if needed) and pinned appropriately
  • PR description explains what changed and how to validate it

@adi-khot adi-khot self-assigned this Feb 18, 2026
@github-actions
Copy link

⚠️ Coverage Report

Overall Coverage: 78.74%

Coverage Status

  • Target: 80% (warning threshold)
  • Current: 78.74%
  • Status: ⚠️ Below target

Coverage reports are informational and do not block PRs.
Generated using pytest-cov

@CassNot
Copy link
Contributor

CassNot commented Feb 19, 2026

Hi @adi-khot !
Could you describe the bug and how you solved it this way ?
Was it tested on test pypi ?

@adi-khot
Copy link
Contributor Author

Hi @CassNot, the bug was in build command. Before we use "python -m build" which uses the setuptools.build_meta driven by pyproject.toml. It does not rely on setup.py.
In the project we use setup.py, so the config is misaligned with package layout, we get failures to create wheel package.
It was tested 2 versions on test pypi with successful creation of source and build distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments