Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: 2.3.5 #185

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Release: 2.3.5 #185

merged 9 commits into from
Jan 17, 2025

Conversation

RyRy79261
Copy link
Contributor

No description provided.

RyRy79261 and others added 8 commits December 18, 2024 12:43
### Description

This PR adds a check to ensure that the balance has loaded as part of
the submit logic

### Related issues

### Checklist before requesting a review

- [x] I have performed a self-review of my own code
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] The PR title follows the
[conventions](https://www.notion.so/Git-Branching-and-Commit-Message-Conventions-18f66f7d06444cfcbac5725ffbc7c04a?pvs=4#9355048863c549ef92fe210a8a1298aa)
- [ ] I have run the [regression
tests](https://www.notion.so/Mento-Web-App-Regression-Tests-37bd43a7da8d4e38b65993320a33d557)

---------

Co-authored-by: Bayological <[email protected]>
Co-authored-by: Gabriel Temsten <[email protected]>
Co-authored-by: Andrew718PLTS <[email protected]>
Co-authored-by: Andrew718PLTS <[email protected]>
Bumps [next](https://github.com/vercel/next.js) from 13.5.7-canary.37 to
14.2.15.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/vercel/next.js/commit/737c29e49f9532cce3da8e25d88bc82cf5f5fe9a"><code>737c29e</code></a>
v14.2.15</li>
<li><a
href="https://github.com/vercel/next.js/commit/1c8234eb20bc8afd396b89999a00f06b61d72d7b"><code>1c8234e</code></a>
backport: [i18n] Routing fix <a
href="https://redirect.github.com/vercel/next.js/issues/70761">#70761</a>
(<a
href="https://redirect.github.com/vercel/next.js/issues/70976">#70976</a>)</li>
<li><a
href="https://github.com/vercel/next.js/commit/bb3f58011885369404fe2d6abe5d40b867183fce"><code>bb3f580</code></a>
fix: Do not omit alt on getImgProps return type, ImgProps (<a
href="https://redirect.github.com/vercel/next.js/issues/70818">#70818</a>)</li>
<li><a
href="https://github.com/vercel/next.js/commit/cb8113bb0dec432470ac82a741670920c8c51d35"><code>cb8113b</code></a>
fix(next/image): handle undefined <code>images.localPatterns</code>
config in `images-ma...</li>
<li><a
href="https://github.com/vercel/next.js/commit/9c1191abccb08b984369e1b488d1ed99f4f9f7f6"><code>9c1191a</code></a>
fix missing helpers in <code>next-test-utils.ts</code></li>
<li><a
href="https://github.com/vercel/next.js/commit/0de418351392e302c9c4538f06d352b1c157a445"><code>0de4183</code></a>
fix lint</li>
<li><a
href="https://github.com/vercel/next.js/commit/e03c4ff4ff53d7ad94dde19c45ed2dd4d94d91f0"><code>e03c4ff</code></a>
feat(next/image): add <code>images.localPatterns</code> config (<a
href="https://redirect.github.com/vercel/next.js/issues/70802">#70802</a>)</li>
<li><a
href="https://github.com/vercel/next.js/commit/540ea2d892b974bd3141faa05824b6118a634c1b"><code>540ea2d</code></a>
backport: support breadcrumb style catch-all parallel routes (<a
href="https://redirect.github.com/vercel/next.js/issues/65063">#65063</a>)
(<a
href="https://redirect.github.com/vercel/next.js/issues/70794">#70794</a>)</li>
<li><a
href="https://github.com/vercel/next.js/commit/0d0448be0345cfa314dab274662bccdf5b8384a3"><code>0d0448b</code></a>
Fix client reference access causing metadata missing (<a
href="https://redirect.github.com/vercel/next.js/issues/70732">#70732</a>)
(<a
href="https://redirect.github.com/vercel/next.js/issues/70788">#70788</a>)</li>
<li><a
href="https://github.com/vercel/next.js/commit/381d1f9a06292758cc94bee7bc702045cff94010"><code>381d1f9</code></a>
feat(next/image): add support for <code>decoding</code> prop (<a
href="https://redirect.github.com/vercel/next.js/issues/70678">#70678</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/vercel/next.js/compare/v13.5.7-canary.37...v14.2.15">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=next&package-manager=npm_and_yarn&previous-version=13.5.7-canary.37&new-version=14.2.15)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/mento-protocol/mento-web/network/alerts).

</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan Noble <[email protected]>
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.6 to 3.3.8.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/ai/nanoid/blob/main/CHANGELOG.md">nanoid's
changelog</a>.</em></p>
<blockquote>
<h2>3.3.8</h2>
<ul>
<li>Fixed a way to break Nano ID by passing non-integer size (by <a
href="https://github.com/myndzi"><code>@​myndzi</code></a>).</li>
</ul>
<h2>3.3.7</h2>
<ul>
<li>Fixed <code>node16</code> TypeScript support (by Saadi
Myftija).</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/ai/nanoid/commit/3044cd5e73f4cf31795f61f6e6b961c8c0a5c744"><code>3044cd5</code></a>
Release 3.3.8 version</li>
<li><a
href="https://github.com/ai/nanoid/commit/4fe34959c34e5b3573889ed4f24fe91d1d3e7231"><code>4fe3495</code></a>
Update size limit</li>
<li><a
href="https://github.com/ai/nanoid/commit/d643045f40d6dc8afa000a644d857da1436ed08c"><code>d643045</code></a>
Fix pool pollution, infinite loop (<a
href="https://redirect.github.com/ai/nanoid/issues/510">#510</a>)</li>
<li><a
href="https://github.com/ai/nanoid/commit/89d82d2ce4b0411e73ac7ccfe57bc03e932416e2"><code>89d82d2</code></a>
Release 3.3.7 version</li>
<li><a
href="https://github.com/ai/nanoid/commit/5022c35acaaedd9da4b56cad37b02bbcb87635e1"><code>5022c35</code></a>
Update dual-publish</li>
<li><a
href="https://github.com/ai/nanoid/commit/3e7a8e557b9d93a582ef2c3bb9f7306fc339ef35"><code>3e7a8e5</code></a>
Remove benchmark from CI for v3</li>
<li><a
href="https://github.com/ai/nanoid/commit/d3561446aee52fdf38325e1d30c905d989a8ccd2"><code>d356144</code></a>
Fix CI for v3</li>
<li><a
href="https://github.com/ai/nanoid/commit/37b25dfac2edfd73d7bbc88886e4c6067fac8619"><code>37b25df</code></a>
Move to pnpm 8</li>
<li>See full diff in <a
href="https://github.com/ai/nanoid/compare/3.3.6...3.3.8">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=nanoid&package-manager=npm_and_yarn&previous-version=3.3.6&new-version=3.3.8)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/mento-protocol/mento-web/network/alerts).

</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ryan Noble <[email protected]>
### Description

This PR addresses an issue where the _Use Max_ button was not displayed
for tokens with balances less than 1. The root cause was the use of
Number.parseInt() to evaluate token balances, which truncates fractional
values, resulting in balances like 0.7 being treated as 0.

**Problem:**

- The Use Max button was visible only when the token balance was greater
than or equal to 1.

- Tokens with fractional balances (e.g., 0.5, 0.7) incorrectly failed
the check.

- This prevented users from using the _Use Max_ functionality for tokens
with balances below 1, potentially impacting usability for
large-token-value ecosystems.

**Solution:**

- Replaced Number.parseInt() with Number.parseFloat() to account for
fractional token balances.

**Impact:**

- Improves user experience by enabling _Use Max_ functionality for all
tokens with balances above 0, regardless of whether the balance is
fractional.

### Tested

- Tested manually by allocating multiple tokens with fractional and
above one amount.

### Related issues

- Fixes #issue number here

### Checklist before requesting a review

- [ ] I have performed a self-review of my own code
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] The PR title follows the
[conventions](https://www.notion.so/Git-Branching-and-Commit-Message-Conventions-18f66f7d06444cfcbac5725ffbc7c04a?pvs=4#9355048863c549ef92fe210a8a1298aa)
- [ ] I have run the [regression
tests](https://www.notion.so/Mento-Web-App-Regression-Tests-37bd43a7da8d4e38b65993320a33d557)

Co-authored-by: chapati <[email protected]>
### Description

Adjusted the `z-index` on drop down & footer components
### Description
Currently, it transforms an amount with >=22 digits to an incorrect
amount and proceeds to the confirmation state (e.g.,
7478773923223123234925 -> 7.479). The scope is to make it the correct
amount with >=22 digits.

### Other changes
None

### Tested
Put 7478773923223123234925 amount and tried to proceed to confirmation
when it exceeded balance

### Related issues

- Fixes #157 

### Checklist before requesting a review

- [x] I have performed a self-review of my own code
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] The PR title follows the
[conventions](https://www.notion.so/Git-Branching-and-Commit-Message-Conventions-18f66f7d06444cfcbac5725ffbc7c04a?pvs=4#9355048863c549ef92fe210a8a1298aa)
- [ ] I have run the [regression
tests](https://www.notion.so/Mento-Web-App-Regression-Tests-37bd43a7da8d4e38b65993320a33d557)

Co-authored-by: Andrew718PLTS <[email protected]>
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mento-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:15am

Copy link
Contributor

@chapati23 chapati23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go

@chapati23 chapati23 merged commit ed97e21 into main Jan 17, 2025
9 checks passed
@chapati23 chapati23 deleted the release/2.3.5 branch January 17, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants