add LockMemcached #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeym
force-pushed
the
add-LockMemcached
branch
from
9226fcb
to
62336c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 83.00% 83.19% +0.18%
==========================================
Files 10 10
Lines 1183 1196 +13
==========================================
+ Hits 982 995 +13
Misses 137 137
Partials 64 64 ☔ View full report in Codecov by Sentry. |
leeym
force-pushed
the
add-LockMemcached
branch
2 times, most recently
from
2c12ad6
to
275e6bf
Compare
leeym
force-pushed
the
add-LockMemcached
branch
3 times, most recently
from
3e404fd
to
1231ac0
Compare
leeym
force-pushed
the
add-LockMemcached
branch
from
1231ac0
to
6f32228
Compare
|
Obsoleted by #33 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @mennanov,
Thank you very much for this interesting library! I really like the clean interface, though in our use case we prefer memcached over redis.
I understand that in extreme situation memcached will evict the oldest entry while redis can be configured to throw errors, but still it is a good trade-off so I plan to add supports for memcached.
I'll start with LockMemcached.