Clear lastVersion in a case of returning an empty TokenBucketState #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 82.93% 83.00% +0.07%
==========================================
Files 10 10
Lines 1178 1183 +5
==========================================
+ Hits 977 982 +5
Misses 137 137
Partials 64 64 ☔ View full report in Codecov by Sentry. |
mennanov
approved these changes
Dec 1, 2023
Comment on lines
+368
to
+371
| if t.raceCheck { | ||
| // reset in a case of returning an empty TokenBucketState | ||
| t.lastVersion = 0 | ||
| } |
There was a problem hiding this comment.
Do you think it makes sense to add the test that covers this?
There was a problem hiding this comment.
Hm.. let's keep the tests generic.
I will merge this PR as is.
mennanov
approved these changes
Dec 4, 2023
Comment on lines
+368
to
+371
| if t.raceCheck { | ||
| // reset in a case of returning an empty TokenBucketState | ||
| t.lastVersion = 0 | ||
| } |
There was a problem hiding this comment.
Hm.. let's keep the tests generic.
I will merge this PR as is.
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #29