QA-508: ci: fix unreliable docker start #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0lmi
changed the title
lluiscampos
approved these changes
Jan 4, 2023
Comment on lines
-185
to
-186
| - unset DOCKER_TLS_VERIFY | ||
| - unset DOCKER_CERT_PATH |
There was a problem hiding this comment.
I don't see gitlab-pipeline/internal-variables.yml is included in any of our templates. All those variables are for accessing dockerd via tcp, which we don't use, and probably all of them can be deleted then.
Just for the reference: unset DOCKER_HOST is required, because the variable is set by GitLab
There was a problem hiding this comment.
Due to internal-variables.yml is not included by the template I would suggest to deal with it separately.
There was a problem hiding this comment.
Follow-up at:
added 4 commits
January 4, 2023 14:43
DOCKER_TLS_VERIFY and DOCKER_CERT_PATH are not set by default in the currently used image versions Changelog: None Ticket: None Signed-off-by: Alex Miliukov <[email protected]>
dockerd might fail from time to time which looks related to the known issue docker-library/docker#318 and using docker-init is the workaround used by the community Changelog: None Ticket: QA-508 Signed-off-by: Alex Miliukov <[email protected]>
Changelog: None Ticket: None Signed-off-by: Alex Miliukov <[email protected]>
Changelog: None Ticket: None Signed-off-by: Alex Miliukov <[email protected]>
|
How comes that we merged this PR without running the pipeline? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: None
Ticket: QA-508
Signed-off-by: Alex Miliukov [email protected]
dockerd might fail from time to time which looks related to the known issue docker-library/docker#318 and using docker-init is the workaround used by the community