Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jwt signer #1464

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Jwt signer #1464

merged 10 commits into from
Jan 13, 2025

Conversation

t-burch
Copy link
Collaborator

@t-burch t-burch commented Jan 10, 2025

No description provided.

predic8 and others added 4 commits January 10, 2025 12:30
@predic8
Initial
a21813f
@t-burch
Implement JWT payload preparation in JwtSignerInterceptor
640b7c3 
Add methods to prepare JWT payloads by including 'iat' and 'exp' fields. Update handleRequest and handleResponse methods to utilize the new payload preparation functionality. Additionally, integrate Jackson ObjectMapper for JSON manipulation. Adjust method signatures to handle IOException.
@t-burch
Fix JWT payload timestamps and update configuration paths
b636033 
Adjust JWT payload preparation to use seconds instead of milliseconds for 'iat' and 'exp' claims. Change expiration time from 300,000 seconds to 300 seconds. Update configuration to change API key file location from './demo-keys.txt' to './keys.txt', and modify JWT signing and validation processes in the proxy definition for improved clarity and correctness.
@t-burch
Refactor SpEL functions to simplify scope handling
c40112e 
Remove deprecated security scopes logic from SpELExchangeEvaluationContext and introduce new scope retrieval methods in BuiltInFunctions. Implement predicates for flexible security scheme filtering.
@membrane-ci-server
Copy link

This pull request needs "/ok-to-test" from an authorized committer.

predic8 and others added 3 commits January 10, 2025 15:54
@predic8
Extended interface SecurityScheme with getName. Use name to get Schem…
42a8a8d 
…es from Exchange
@predic8
Sample
8487ce2
@t-burch
Add BasicHttpSecurityScheme and expand scope tests in BuiltInFunction…
1dd1c0e 
…sTest

- Introduce BasicHttpSecurityScheme alongside ApiKeySecurityScheme in BuiltInFunctionsTest.
- Implement tests for obtaining all scopes and scheme-specific scopes.
- Rename APIKeyTest to APIKeySimpleExampleTest for clarity.
- Update proxy configuration to display caller scopes in response messages.
- Rename APIKeyRBACTest to APIKeyRBACExampleTest for consistency.
predic8
predic8 requested changes Jan 13, 2025
View reviewed changes
Copy link
Member

@predic8 predic8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix

@t-burch
Rename JwtSignerInterceptor to JwtSignInterceptor and add expiry time…
148fd2f 
… configuration

- Rename class JwtSignerInterceptor to JwtSignInterceptor for clarity.
- Update logger name accordingly.
- Introduce configurable expiry time with a default value in seconds.
- Modify JWT expiration logic to utilize the new configurable expiry time.
- Clean up method signatures by removing unnecessary IOException declarations.
predic8
predic8 previously approved these changes Jan 13, 2025
View reviewed changes
@predic8 predic8 merged commit a3dadea into master Jan 13, 2025
2 checks passed
@predic8 predic8 deleted the jwt-signer branch January 13, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@predic8 predic8 predic8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-burch @predic8