Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Expand test coverage to background.ts and refactor sendToBackground method #1449

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

tora-pan
Copy link
Contributor

Split original branch into to separate branches in order to be able to merge logic and test changes separately.

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@d7c4c8f). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1449   +/-   ##
=======================================
  Coverage        ?   80.16%           
=======================================
  Files           ?        7           
  Lines           ?     2999           
  Branches        ?      186           
=======================================
  Hits            ?     2404           
  Misses          ?      590           
  Partials        ?        5           
Impacted Files Coverage Δ
extension/rikaichan.ts 87.70% <ø> (ø)
extension/background.ts 97.40% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tora-pan tora-pan changed the title test(background): Expand test coverage fix: Resolve hovering over ruby text bug that ended up searching for an empty string that returns orangutang. Mar 14, 2023
@tora-pan tora-pan changed the title fix: Resolve hovering over ruby text bug that ended up searching for an empty string that returns orangutang. fix: Resolve hovering over ruby text bug that ended up searching for an empty string that returns orangutang Mar 14, 2023
Copy link
Owner

@melink14 melink14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it still contains the changes from the other PR. :(

Also, I'm not sure why the title was changed as it was since you already have a PR which is about fixing the bug!

As I said in the chat, you can try again or let me know if you want to work through it together!

@tora-pan
Copy link
Contributor Author

@melink14 Do I need to add these tests changes to their own branch? Will that clean things up?

@melink14
Copy link
Owner

@melink14 Do I need to add these tests changes to their own branch? Will that clean things up?

Yes, in this one I would just make a new branch off of main and then copy just the test file into it. (we can also wait til we land the first change if you want to reuse the helper methods you made)

@tora-pan tora-pan changed the title fix: Resolve hovering over ruby text bug that ended up searching for an empty string that returns orangutang test: Expand test coverage to background.ts and refactor sendToBackground method Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants