-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Expand test coverage to background.ts and refactor sendToBackground
method
#1449
base: main
Are you sure you want to change the base?
test: Expand test coverage to background.ts and refactor sendToBackground
method
#1449
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1449 +/- ##
=======================================
Coverage ? 80.16%
=======================================
Files ? 7
Lines ? 2999
Branches ? 186
=======================================
Hits ? 2404
Misses ? 590
Partials ? 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…kground-test-coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it still contains the changes from the other PR. :(
Also, I'm not sure why the title was changed as it was since you already have a PR which is about fixing the bug!
As I said in the chat, you can try again or let me know if you want to work through it together!
@melink14 Do I need to add these tests changes to their own branch? Will that clean things up? |
Yes, in this one I would just make a new branch off of main and then copy just the test file into it. (we can also wait til we land the first change if you want to reuse the helper methods you made) |
sendToBackground
method
Split original branch into to separate branches in order to be able to merge logic and test changes separately.