Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use instanceof to safely downcast (#182)" #6

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

jchavarri
Copy link
Member

This reverts commit 17b2822 (original PR reasonml-community/bs-webapi-incubator#182).

This change seems to have affected the way input elements are handled, making it impossible to use, see reasonml-community/bs-webapi-incubator#205 and TheSpyder/rescript-webapi#60.

@jchavarri jchavarri merged commit 3fa3259 into master Aug 23, 2023
@jchavarri jchavarri deleted the undo-instanceof-pr branch August 23, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant