Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support facet distribution for federated search #1743

Merged
merged 1 commit into from
Oct 10, 2024
Merged

feat: support facet distribution for federated search #1743

merged 1 commit into from
Oct 10, 2024

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented Oct 10, 2024

Pull Request

Related issue

Fixes #1713

What does this PR do?

  • Addition of the facetsByIndex field on multi-search requests
  • Addition of the mergeFacets field on multi-search requests
  • Addition of new tests
  • Rename the indexUid of the test dataset from "movies_test" to "books" since we're sending books (no effet on the tests)

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@mdubus mdubus added the enhancement New feature or request label Oct 10, 2024
@mdubus mdubus marked this pull request as ready for review October 10, 2024 09:57
@mdubus mdubus requested a review from curquiza October 10, 2024 09:58
curquiza
curquiza approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muchas gracias!!

@curquiza curquiza merged commit edf3af0 into bump-meilisearch-v1.11.0 Oct 10, 2024
6 checks passed
@curquiza curquiza deleted the v1.11/support_facet_distribution_for_federated_search branch October 10, 2024 10:16
@curquiza curquiza mentioned this pull request Oct 10, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdubus @curquiza