-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add makefile and badges for readme #561
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage 86.73% 86.73%
=======================================
Files 11 11
Lines 2043 2043
=======================================
Hits 1772 1772
Misses 165 165
Partials 106 106 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ja7ad for the PR, as usual ❤️
Can you update our CONTRIBUTING to explain how to use the makefile -> at Meilisearch, we are not familiar with Go good practices and since we manage a lot of different environment, we need CONTRIBUTING to guide us when coming back on the repo 😊
I will update it |
@curquiza Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
bors merge
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!