Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add makefile and badges for readme #561

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

Ja7ad
Copy link
Collaborator

@Ja7ad Ja7ad commented Aug 15, 2024

What does this PR do?

  • This PR add codecov and go reference badge in readme and add makefile for easyjson and test.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.73%. Comparing base (7bd9c23) to head (11b1bd5).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   86.73%   86.73%           
=======================================
  Files          11       11           
  Lines        2043     2043           
=======================================
  Hits         1772     1772           
  Misses        165      165           
  Partials      106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ja7ad for the PR, as usual ❤️

Can you update our CONTRIBUTING to explain how to use the makefile -> at Meilisearch, we are not familiar with Go good practices and since we manage a lot of different environment, we need CONTRIBUTING to guide us when coming back on the repo 😊

@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Aug 20, 2024
@Ja7ad
Copy link
Collaborator Author

Ja7ad commented Aug 20, 2024

Thanks @Ja7ad for the PR, as usual ❤️

Can you update our CONTRIBUTING to explain how to use the makefile -> at Meilisearch, we are not familiar with Go good practices and since we manage a lot of different environment, we need CONTRIBUTING to guide us when coming back on the repo 😊

I will update it

@Ja7ad
Copy link
Collaborator Author

Ja7ad commented Aug 21, 2024

@curquiza Updated CONTRIBUTING.md

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

bors merge

Copy link
Contributor

meili-bors bot commented Aug 21, 2024

@meili-bors meili-bors bot merged commit a5a58fb into meilisearch:main Aug 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants