HTTP Signare 検証の修正 #2719
Merged
HTTP Signare 検証の修正 #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* validate signed headers * リクエストホスト Co-authored-by: perillamint <[email protected]> Co-authored-by: yunochi <[email protected]> Co-authored-by: Laura Hausmann <[email protected]>
|
ねんのためraw assert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
mei23/misskey-v11#2497
mei23/misskey-v11#2498
mei23/misskey-v11#2501
(request-target),digest,host,dateが含まれてない場合はエラーにするように。dateが300秒以上ずれている場合 (主にどちらかの時計が狂っている場合) 弾かれるようになります。この仕様はhttp-signatureのclock-skewによるもの
https://github.com/TritonDataCenter/node-http-signature/blob/master/http_signing.md#clock-skew
ものすごく古いPleromaは
(request-target)に署名していないため、受け入れられなくなります。md5とsha1署名は受け入れられなくなります
なお、ed25519の場合は常にsha512になります。
hs2019を指定した場合は
ed25519鍵が与えられた場合は、ed25519-sha512として扱い
それ以外は、鍵-sha256として扱います。