Fix Dockerfile

[guillaumelambert]

Requests is no more installed in python:3.11-slim-bullseye image.

Issue: #209

[Pshepp]

Seems cleaner and more robust to, instead of handling the install through the dockerfile, respect the projects design pattern and add ,"requests" to

holehe/setup.py

Line 11 in 14da70f

install_requires=["termcolor","bs4","httpx","trio","tqdm","colorama"],

Tested this locally and it works well. The setup.py file is also used when installing the project on bare metal.

[guillaumelambert]

Seems cleaner and more robust to, instead of handling the install through the dockerfile, respect the projects design pattern and add ,"requests" to

holehe/setup.py

Line 11 in 14da70f

install_requires=["termcolor","bs4","httpx","trio","tqdm","colorama"],

Tested this locally and it works well. The setup.py file is also used when installing the project on bare metal.

Thanks for the feedback. Please Feel free to propose the related PR.
There is always a debate how should python dependecies be installed.
Both methods are perfectly acceptable IMHO and are really up to the maintainer.
I won't say using setup.py is cleaner or more robust.
It can encourage bad practices such a running pip install under root.
If it can be OK under certains circumstances or in a docker container, it is usually not on a production system.
When possible, I prefer to rely on system packages validated by the distribution maintainers.
At first glance, it may look more robust here but there are some cons.
setup.py is still supported but tends to be replaced by project.toml now
Note also the syntax python setup.py install works but is no more recommanded and has been superseded python -m pip install
Hope this helps